Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SA1015: using time.Tick leaks the underlying ticker #35

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: SA1015: using time.Tick leaks the underlying ticker #35

merged 1 commit into from
Jan 21, 2025

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Jan 10, 2025

This PR fixes this small memory leak:

using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (SA1015)

@sjinks sjinks self-assigned this Jan 10, 2025
@sjinks sjinks merged commit 0ee103d into trunk Jan 21, 2025
1 check passed
@sjinks sjinks deleted the fix/memleak branch January 21, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinatkhaziev rinatkhaziev rinatkhaziev approved these changes

Assignees

@sjinks sjinks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjinks @rinatkhaziev