fix: ignore CR in WP CLI TTY #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures the terminal to ignore CR characters. This fixes the
--promptoption for WP CLI.Ref: pbq1wL-1LP#comment-1898
VIP CLI sends the
<Enter>key as a sequence of<CR><LF>characters. Because WP CLI runs in a Linux environment, it is not prepared to see theCRcharacter. As a result, when we specify the--promptoptions, all arguments end up having the<CR>suffix.This PR updates the terminal settings by setting the Ignore carriage return on input on the TTY descriptor. This emulates the Linux-like behavior.