-
Notifications
You must be signed in to change notification settings - Fork 836
Forms: add "is exporting" state to the export endpoint handler #45302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 4 files.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
I am closing this PR since I cherry-picked these changes to the original PR. Thanks @simison ! |
Implements loading state suggestion from #45275 (comment)
There's a weird delay before the window shows up after button returns to normal, and button doesn't quite look like
isBusy
looks at docs:Screen.Recording.2025-09-25.at.12.47.08.mov
Docs button:
Screen.Recording.2025-09-25.at.12.49.33.mov
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: