Skip to content

Conversation

simison
Copy link
Member

@simison simison commented Sep 25, 2025

Implements loading state suggestion from #45275 (comment)

There's a weird delay before the window shows up after button returns to normal, and button doesn't quite look like isBusy looks at docs:

Screen.Recording.2025-09-25.at.12.47.08.mov

Docs button:

Screen.Recording.2025-09-25.at.12.49.33.mov

Proposed changes:

  • Adds "isExporting" alongside onExport and use it in the download button

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@simison simison requested review from enejb and lezama September 25, 2025 09:46
@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Forms labels Sep 25, 2025
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/add-rest-export-endpoint-isExporting branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forms/add-rest-export-endpoint-isExporting

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-endpoint.php 620/755 (82.12%) -6.68% 62 💔
projects/packages/forms/src/contact-form/class-contact-form-plugin.php 425/1318 (32.25%) -0.24% 12 💔
projects/packages/forms/src/dashboard/hooks/use-export-responses.ts 0/45 (0.00%) 0.00% 3 ❤️‍🩹
projects/packages/forms/src/dashboard/inbox/export-responses/csv.tsx 0/7 (0.00%) 0.00% -9 💚

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@enejb
Copy link
Member

enejb commented Sep 26, 2025

I am closing this PR since I cherry-picked these changes to the original PR. Thanks @simison !

@enejb enejb closed this Sep 26, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 26, 2025
@simison simison deleted the forms/add-rest-export-endpoint-isExporting branch September 26, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants