-
Notifications
You must be signed in to change notification settings - Fork 834
Forms: add read/unread state to the UI #45350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 6 files. Only the first 5 are listed here.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests fairly well and is an exciting change to see.
The good:
- Once this PR is loaded, any new form responses show as unread (with red dot).
- Interacting with unread messages updates status to read (no more dot)
- Selecting items in bulk and clicking the "Mark unread" button successfully marks them unread (with red dot).
- Using the actions dropdown for a single response to mark an item read or unread works.
- Tests pass
Potential improvements:
- The dot in my testing is small and red. I like the bigger, blue one in the PR description a bit more :). It is a shame we can't otherwise style the un-read item rows more (ie, bolding or background color).
- Could be done in a follow up, but now that feedback objects have an unread property, I wonder if we could use that to determine the number we show in the notifications bubble in the admin menu for Jetpack and Forms. As is, these are totally unconnected.
- Example: Say I have 5 unread messages and I see that button Jetpack and Forms. Soon as I click the inbox, that gets cleared even though I still have unread messages. Also marking message read or unread also doesn't affect that.
- There's a small TS error that needs resolving.

Thanks for the review @edanzer!
Yes we should. This part needs updating. ( I think we should switch to a new option ) and go and update the total unread, Everytime we add a new response and when we switch the read state. Ideally this value would also change as we update the count live on the page. I updated design to be indicate that the Response is unread by making the different elements bold. ![]() |
…hem as read once they are viewed
bd305b5
to
1e06088
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Fixes FORMS-302
Adds new feedback/read endpoint and the new UI that lets you mark feedback as read and unread.
This new state is shown as a dot. this is due to the current limitation of the data views which prevent the whole row from being bold.
Proposed changes:
Other information:
Jetpack product discussion
See FORMS-302
Does this pull request change what data or activity we track or use?
No
Testing instructions: