Skip to content

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Oct 2, 2025

Fixes DOTCOM-14858

Proposed changes:

  • Removes the P2_Admin_Menu class and moves all the menu overrides for P2 sites to jetpack-mu-wpcom
  • Hide several menus that were mistakenly visible on P2 sites as noted in pfsHM7-1FH-p2

P2 Hub

Before After
Screenshot 2025-10-02 at 16 15 12 Screenshot 2025-10-02 at 16 14 57

P2 Space

Before After
Screenshot 2025-10-02 at 16 15 19 Screenshot 2025-10-02 at 16 14 43

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes to your WP.com sandbox
  • Sandbox a P2 Hub site (e.g. automatticp2)
  • Go to WP Admin
  • Make sure that the following menus are not visible:
    • Dashboard
    • My Home
    • Stats
    • Upgrades > Domains
    • Upgrades > Emails
    • Jetpack
    • Posts
    • Pages
    • Media
    • Comments
    • Feedback
    • Appearance
    • Plugins
    • Tools > Available Tools
    • Tools > Marketing
    • Tools > Site Health
    • Tools > Export Personal Data
    • Tools > Erase Personal Data
    • Tools > Plugin Editor
    • Tools > Theme Editor
    • Tools > Import
    • Tools > Export
    • Tools > Export Media Files
    • Settings > Reading
    • Settings > Writing
    • Settings > Discussion
    • Settings > Media
    • Settings > Permalink
    • Settings > Privacy
    • Settings > Sharing
    • Settings > Crowdsignal
    • Settings > Ratings
    • Settings > ActivityPub
  • Sandbox now a P2 Space site (e.g. trexp2)
  • Go to WP Admin
  • Make sure that the following menus are not visible:
    • Upgrades
    • Jetpack
    • Feedback
    • Appearance > Additional CSS
    • Plugins
    • Tools > Available Tools
    • Tools > Marketing
    • Tools > Site Health
    • Tools > Export Personal Data
    • Tools > Erase Personal Data
    • Tools > Plugin Editor
    • Tools > Theme Editor
    • Settings > Permalink
    • Settings > Privacy
    • Settings > Sharing
    • Settings > Crowdsignal
    • Settings > Ratings
    • Settings > ActivityPub

@mmtr mmtr requested a review from a team October 2, 2025 13:31
@mmtr mmtr self-assigned this Oct 2, 2025
@mmtr mmtr added [Status] Needs Review This PR is ready for review. [Type] Task labels Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotcom-14858-calypso-cleanup-remove-p2_admin_menu-class branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack dotcom-14858-calypso-cleanup-remove-p2_admin_menu-class
bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-14858-calypso-cleanup-remove-p2_admin_menu-class

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Package] Masterbar labels Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php 0/412 (0.00%) 0.00% 2 ❤️‍🩹
projects/packages/masterbar/src/admin-menu/load.php 0/42 (0.00%) 0.00% -4 💚

1 file is newly checked for coverage.

File Coverage
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/p2-admin-menu.php 0/55 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Package] Masterbar [Status] Needs Review This PR is ready for review. [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant