Skip to content

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Oct 4, 2025

Summary

Preloads the first page of inbox responses and essential endpoints for instant UI rendering.

Changes

  • Preload initial inbox responses (first 20 items with full fields)
  • Preload /wp/v2/types?context=view for entity type registration
  • Preload /wp/v2/feedback/counts for status counts
  • Preload /wp/v2/feedback/filters for filter options
  • Normalize cache keys to match apiFetch requests (removes domain)
  • Add required WordPress dependencies (wp-data, wp-core-data, wp-dom-ready)

Performance Impact

  • Eliminates multiple initial network requests
  • Data available immediately when React app loads
  • Significantly reduces perceived load time

Related

Main PR: #45339

Copy link
Contributor

github-actions bot commented Oct 4, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/optimize-inbox-preloading branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forms/optimize-inbox-preloading

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 4, 2025
Copy link

jp-launch-control bot commented Oct 4, 2025

Code Coverage Summary

Coverage changed in 7 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/class-dashboard.php 23/110 (20.91%) -6.80% 27 💔
projects/packages/forms/src/dashboard/store/resolvers.js 4/20 (20.00%) -20.00% 13 💔
projects/packages/forms/src/dashboard/store/actions.js 6/12 (50.00%) 0.00% 1 ❤️‍🩹
projects/packages/forms/src/dashboard/components/empty-spam-button/index.tsx 29/31 (93.55%) 0.44% 0 💚
projects/packages/forms/src/dashboard/components/empty-trash-button/index.tsx 29/31 (93.55%) 0.44% 0 💚

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

'/wp/v2/feedback/config',
'/wp/v2/feedback/config?_locale=user',
'/wp/v2/feedback/integrations?version=2',
'/wp/v2/feedback/integrations?version=2&_locale=user',
Copy link
Contributor

@edanzer edanzer Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed ?_locale=user from these endpoints, but I think we need to keep them. I just added them here to fix preloading not working. The issue is that apiFetch adds that to endpoints, so we need the endpoints we list here to exactly match what apiFetch calls. If we're going to remove something, we should remove the versions without the extra query param. That would make sense as long as we're always using apiFetch to call them.

Copy link
Contributor

@edanzer edanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing an extended spinner (maybe 4-8 seconds) on the forms dashboard with this PR, which would suggest the endpoint for getting feedback isn't being pre-loaded as expected. Assuming it's not preloading, the most likely culprit is that we're missing or have wrong order on some query param so that our preload url and the one actually fetched don't quite match.

inbox-spinner

@lezama lezama force-pushed the forms/optimize-inbox-preloading branch from 14a942d to e107dcc Compare October 9, 2025 21:27
@CGastrell CGastrell force-pushed the forms/optimize-inbox-preloading branch from dccc5e3 to 0cf2f16 Compare October 10, 2025 00:09
@lezama lezama force-pushed the forms/optimize-inbox-preloading branch from 0cf2f16 to d443fe4 Compare October 10, 2025 00:24
@CGastrell CGastrell force-pushed the forms/optimize-inbox-preloading branch from d443fe4 to 3eb6c49 Compare October 10, 2025 00:36
@lezama lezama merged commit cb1c899 into trunk Oct 10, 2025
65 of 67 checks passed
@lezama lezama deleted the forms/optimize-inbox-preloading branch October 10, 2025 01:04
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants