Forms: Optimize inbox loading state #45453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
useEntityRecordscontextfrom'view'to'edit'to match whatuseEntityRecordsautomatically addsorderandorderbyparameters to DataViews query args for consistency with preloadsearchparameter when non-empty (PHP'sadd_query_argskips empty values)contextfrom Redux reducer default state (sinceuseEntityRecordsadds it automatically)Result: The feedback endpoint request now uses preloaded data instead of making a duplicate network request on initial page load.
Other information:
Jetpack product discussion
N/A - Performance optimization
Does this pull request change what data or activity we track or use?
No
Testing instructions:
feedback/wp/v2/feedback?context=edit&order=desc&orderby=date&page=1&per_page=20&status=draft%2Cpublish&_locale=userrequestsRef: #45339