Skip to content

Conversation

@lezama
Copy link
Contributor

@lezama lezama commented Oct 10, 2025

Proposed changes:

  • Fix Forms inbox preload parameters to match the actual feedback endpoint requests made by useEntityRecords
  • Update PHP preload context from 'view' to 'edit' to match what useEntityRecords automatically adds
  • Add order and orderby parameters to DataViews query args for consistency with preload
  • Only include search parameter when non-empty (PHP's add_query_arg skips empty values)
  • Remove context from Redux reducer default state (since useEntityRecords adds it automatically)

Result: The feedback endpoint request now uses preloaded data instead of making a duplicate network request on initial page load.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A - Performance optimization

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Open your browser's DevTools and go to the Network tab
  • Filter requests by feedback
  • Navigate to Jetpack → Forms → Inbox
  • Before this PR: You would see two identical /wp/v2/feedback?context=edit&order=desc&orderby=date&page=1&per_page=20&status=draft%2Cpublish&_locale=user requests
  • After this PR: You should no more requests
  • Verify the inbox loads correctly with form responses displayed
  • Test filtering, searching, and pagination to ensure functionality still works

Ref: #45339

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/optimize-inbox-loading-state branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forms/optimize-inbox-loading-state

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@lezama lezama force-pushed the forms/optimize-inbox-loading-state branch from 74e5945 to d64db36 Compare October 10, 2025 02:19
@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@lezama lezama merged commit 29744b3 into trunk Oct 10, 2025
68 of 69 checks passed
@lezama lezama deleted the forms/optimize-inbox-loading-state branch October 10, 2025 02:32
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants