Sharing: show legacy settings on block themes so users can disable sharing#50257
Sharing: show legacy settings on block themes so users can disable sharing#50257shsajalchowdhury wants to merge 2 commits into
Conversation
…aring When a block-based theme is active, the sharing settings page replaced the full services configuration with only a Site Editor prompt. This made it impossible for users to disable legacy sharing buttons that are appended to post content via the_content filter. Fix: Always render services_config_display() below the block theme message, so users retain full control over legacy sharing settings. Fixes Automattic#49495
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
| @@ -0,0 +1,4 @@ | |||
| Significance: patch | |||
| Type: fixed | |||
There was a problem hiding this comment.
Could you create the changelog entry again? This is incorrect.
Error: Type must be "major", "enhancement", "compat", "bugfix", or "other".
I would recommend using the built-in CLI tool to generate those entries, to avoid such issues.
| Type: fixed | |
| Type: bugfix |
What
Fixes #49495
Why
When a block-based theme is active on a self-hosted Jetpack site, the Sharing settings page (
Settings > Sharing) replaces the full services configuration UI with only a Site Editor prompt. This hides all controls for managing legacy sharing buttons, making it impossible for users to disable the sharing buttons that are automatically appended to post content viathe_contentfilter.Users have to switch back to a classic theme, disable sharing, then switch back to their block theme — which is a poor UX.
How
Instead of replacing
services_config_display()withsharing_block_display(), show both:Testing Instructions
Changelog
Does this pull request change what data or activity we track or use?
No. This change only modifies what UI is shown on the Sharing settings page — no data collection or tracking changes.
Testing instructions