Podcast Episode: render the player in all contexts#50286
Open
arcangelini wants to merge 3 commits into
Open
Conversation
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The Podcast Episode block used to only show its full player on the front end of a site. Everywhere else — RSS feed, Reader on Atomic/Jetpack sites — you just got a plain "listen" link.
This makes the block render the full player in every context. Because the player now lives in the RSS feed, the WPCOM Reader picks it up on Atomic/Jetpack sites too, with no wpcom-side change.
Also:
<audio>/<video>tags carry a plain link inside them, so clients that strip the player still show something clickable.render_email().Does this pull request change what data or activity we track or use?
No.
Testing instructions
/feed/) — the item should contain the full player markup (jetpack-podcast-episode__player,<audio>/<video>), not just a bare link.wordpress.com/read) — the player should render.