nano: add the terminal editor leaf formula#34
Conversation
a6e58d2 to
23f0533
Compare
bc087b1 to
c5e292f
Compare
23f0533 to
93567f2
Compare
93b5267 to
672239c
Compare
672239c to
6ab0121
Compare
6ab0121 to
1807a29
Compare
|
Independent devil's-advocate source-only review at The review rechecked the declared GNU Nano 8.0 source and GPL-3.0-or-later licensing, direct ncurses dependency and upstream pkg-config overrides, stable guest sysconf path, final-binary fork instrumentation, installed The diff is source-only: one formula, with no bottle block, sidecar, archive, receipt, provenance metadata, or other binary artifact. Historical ABI 18 bottle inspection was used only as implementation evidence; trusted bottles must be rebuilt from the merged formula. No source-formula blocker remains. |
Purpose
Add GNU Nano 8.0 as a first-class Kandelo terminal-editor formula. It follows the normal Homebrew path: verified upstream source, a declared tap ncurses dependency, the real editor and data files, final fork instrumentation, and a real PTY edit workflow in
brew test.Dependency topology
Ncurses PR #8 is merged, and
automattic/kandelo-homebrew/ncursesis Nano's explicit direct dependency. The registry manifest omitted this edge even though its build script resolved and linked ncurses; the formula records the actual dependency instead of relying on ambient registry state.Formula contract
/home/linuxbrew/.linuxbrew/etc/nanorcas the guest-stable system configuration path.nano,rnano, documentation, manpages, and syntax data.Source acceptance
The source formula may merge independently after a fresh source-only devil review. This PR contains no bottle block or Nano sidecar, and merging it does not claim that a bottle is published or installable.
Existing runtime evidence
Pre-final ABI 18 source and bottle-resolver runs passed the Node PTY workflow and equivalent Chromium workflow. The tested executable had ABI 18, imports only from
envandkernel, all fivewpk_fork_*exports, no Asyncify residue, and no host build paths in runtime payload files.The previously reported local bottle SHA-256
b3440b94147780f7c9caf519a6f57c081b25d2050b46166dcc2dff865b0427a2is historical evidence only and is rejected for publication.Final source validation
The two Nano semantic commits and installed-tap loader commit were based on tap
mainata3ede334ad27aac7c4d5826bac761b9faf768f20. Before merge, an independent source-only review verified a clean merge tree against then-current tapmainat594ad5514dd03b18ce0996cc0aaf6e081202f229.git range-diffreports all three commits unchanged from the already validated b9df206 restack.672239c; the formula-tail SHA-256 is2197e96ce0058dad3ccdacb21ae4df7b50c765b0ae3ce0bb97d739fc2c74e53e.brew style Formula/nano.rbreported no offenses.Tap.fetchreturnedNano; installed and branch support files both had SHA-256f5f13ecbee24d8d87e50a6f457c5acd23c3fdee7af1cca1fb9f428bf9d021766.git diff --checkpassed and the worktree is clean.No source build or runtime suite was rerun for this history/import-only restack. Current head is
1807a29f089446ed1680251c0d85a7adaf7856c5.Bottle gates
Final bottle construction, publication, and installability claims remain gated on:
Automattic/kandelo#867 is merged ABI 18 baseline, not a pending gate. No platform ABI changes are made here. Firefox, WebKit, wasm64, and a final poured-bottle PTY run are not yet claimed.