Preserve guest stderr on normal browser exits#875
Open
brandonpayton wants to merge 2 commits into
Open
Conversation
Member
Author
|
CI note: the failing |
This was referenced Jul 11, 2026
ab81924 to
c10f58c
Compare
cbbec5c to
ed3f2af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The browser worker logged a normal nonzero process exit with
console.warnand also posted the same host diagnostic as a gueststderrevent. Node does not alter guest stderr for normal nonzero exits. Commands such asfalse, grep no-match, and shell children that intentionally return a nonzero status therefore had browser-only, non-POSIX stderr output.The diagnostic remains available in the browser console. Only the guest-visible stderr injection is removed.
Validation
On the history-only stack over #889 (
bcd704a6aa7678f8ef326cb7f65003db971b8d02):./scripts/dev-shell.sh npm --prefix host run typecheck./scripts/dev-shell.sh bash -c "cd apps/browser-demos && npx playwright test --list test/browser-nonzero-exit-stderr.spec.ts --project=chromium"(1 test listed)git range-diff 31e77f56b..ab819240c origin/main..HEAD(semantic commit unchanged)git diff --check origin/main...HEADThe pre-rebase exact ABI 18 Chromium probe using the staged Homebrew Dash artifact returned
exitCode=7, empty stdout/stderr/combined output, and one browser-console diagnostic. That is historical semantic evidence.Hosted attempt 3 proved the repaired public ABI 18 ledger materializes all 66 required packages, then exposed a test-fixture bug before Kandelo started: the new spec hardcoded a developer-local
local-binariesDash path while CI correctly materializes fetched package bytes underbinaries. The spec now uses the authoritativeresolveBinary("programs/dash.wasm")contract. A fetch-only resolver run with no local Dash selected the fetched symlink and read 459,958 bytes; Playwright compiled the corrected spec and listed its single Chromium test. Hosted CI will run the behavior test on exact headed3f2afae64d260d906f7d712b21d8eb558998a8.git range-diffreports both #875 commits patch-identical; the only new parent is #889's separately reviewed test-readiness correction.The complete browser suite was not run locally. App-wide
tsc --noEmitwas attempted but remains red on existing unrelated app/host typing debt; it reported no error in this spec. Attempt 3's Vitest failure is the known pre-#889 teardown readiness race and is unrelated to this change. No ABI or guest artifact changes.