MariaDB: share writable-directory setup across VFS images#896
Open
brandonpayton wants to merge 1 commit into
Open
MariaDB: share writable-directory setup across VFS images#896brandonpayton wants to merge 1 commit into
brandonpayton wants to merge 1 commit into
Conversation
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| lamp | wasm32 | built | c2b144d6 |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
Member
Author
|
Before the post-#907 rewrite, this PR pointed at |
ebb2a09 to
224aeeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
#907 already put the shared MariaDB writable-directory helper and its serialized-image ownership regression on
main.This PR keeps the small part that was still unique:
What I removed
I dropped the duplicate ownership implementation, the already-landed helper and test, and the stale MariaDB/LAMP revision changes from the old branch. The old head was
ebb2a09f3b34e0d00b68791c207caa52d3192018.ABI and package artifacts
There is no ABI change; the ABI 39 snapshot and generated bindings remain unchanged.
The LAMP cache key now includes the helper file, but the helper refactor does not change the directory bytes: the old inline setup and shared helper produced byte-identical raw VFS images (
2f4e0cb3...for both). Full LAMP rebuilds had the same 8,710 entries, image metadata, file types, modes, owners, groups, and sizes. Rebuild-to-rebuild content drift was limited to generated MariaDB/WordPress database files and one OPcache file. Package revision stays at 8.Validation run
All commands ran through
scripts/dev-shell.sh../run.sh browserreached the Vite server; the WordPress MariaDB page was inspected and showed the preinstalled site running;I also ran the older slow WordPress login test. It reached the login form but timed out because its direct submit click is covered by the guide popover; the maintained merge-gate test uses the guide login action and passed. That failure is unrelated to this diff.
Validation not run
Firefox, WebKit, the full slow browser suite, external libc/POSIX/Sortix suites, and performance benchmarks were not run. This is not a performance change and makes no performance claim.