mkrootfs: emit complete inspect output#920
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
Allow Node to flush asynchronous stdout writes before normal shutdown so large inspect output is not truncated. Treat stdout EPIPE as normal pipeline termination when a consumer closes early, while preserving other stream failures.
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| rootfs | wasm32 | built | d27191fb |
| shell | wasm32 | built | 8c8724d2 |
| lamp | wasm32 | built | af4ac801 |
| node-vfs | wasm32 | built | 71c76ec3 |
| wordpress | wasm32 | built | 08d29526 |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
Member
Author
|
Replacement batch #921 preserves this PR exact patch as commit |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mkrootfs inspect --format jsoncalledprocess.exit()as soon as the command promise resolved. Node could terminate before buffered stdout drained, so a 1,501-entry image produced only 65,536 of 198,111 bytes and invalid JSON.Fix
process.exitCodeafter command completion so normal event-loop shutdown drains stdout.EPIPEas a normal early-closing consumer, while leaving other stream errors visible.Evidence
All commands ran through
scripts/dev-shell.shwith Node 24.15.0.head -c 1consumerEIOtools/mkrootfssuite: 135/135 passed.Scope
This changes only CLI process shutdown and its tests. It does not change the Kandelo runtime, Node/browser host behavior, VFS format, ABI, packages, or release artifacts. Broad runtime and browser suites were not run because those paths are unaffected.