SQLite tests: clean up TestRecover commands#933
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 13, 2026
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| sqlite | wasm32 | built | 5a13e73a |
| sqlite | wasm64 | built | d7ce2dd3 |
| php | wasm32 | built | 9fd390fa |
| lamp | wasm32 | built | ca2226cc |
| wordpress | wasm32 | built | 0eb6e1e7 |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
Member
Author
|
Closing this focused source PR because its unique TestRecover command-lifetime work is now carried by #934 at exact green head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
#907 already landed PHP support, ABI 39, and the shared runtime, VFS, process,
networking, package, and Vitest fixes found while bringing PHP up. This PR does
not replay any of that work.
The unique work here fixes the upstream SQLite testfixture's
TestRecoverTclbinding. A generated recovery command now owns its
sqlite3_recoverhandle,cleans it up when the command is deleted or the interpreter exits, and still
deletes the right command after a Tcl rename. A focused upstream-style test
covers finish, deletion, rename, and repeated direct/SQL-callback lifecycles.
This is stacked on #932 so the SQLite test patches have one clear order. The
new patch is testfixture-only and is deliberately kept out of
build-sqlite.sh.What was removed
are included.
no_mutexworkaround or broad pager-fault omission is included.headers, and pkg-config outputs do not change.
ABI and package impact
There is no kernel, host-runtime, or ABI change. The non-published
testfixture.wasmbytes change; the published SQLite package outputs do not.This PR adds no package revision beyond the revisions already present in the
stack.
Validation run
The focused slice was built from a clean current-main worktree through
scripts/dev-shell.sh:testfixture builds completed;
SHA-256 both times;
commands, and one live allocation;
live allocations;
hook integration needed by SQLite tests: use the UTF-16 STAT4 allocation range #932's existing testfixture patch loop.
Validation not run
The full SQLite upstream matrix, full Vitest suite, wasm64, and conformance
suites were not rerun locally for this testfixture-only change. GitHub staging
will validate the exact restacked head.
Extracted from the useful TestRecover portion of #769.