xtask: ensure resolver tests use current ABI#935
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
The package resolver correctly rejects empty and exportless program artifacts, but six older tests still produced those stale fixtures. That made one remote-fetch test fall back to a forbidden source build and five symlink tests fail before reaching the behavior they cover. The archive-stage smoke test also passed the current shared ABI while asserting an ABI 4 filename. Generate structurally valid test Wasm from the shared required-export contracts, derive the smoke-test filename from ABI_VERSION, and add a negative guard that preserves fail-closed artifact validation. Production resolver behavior is unchanged. Validation: scripts/dev-shell.sh bash -c "cargo test -p xtask --target aarch64-apple-darwin" (350 passed).
brandonpayton
changed the title
brandonpayton
added
the
ready-to-ship
Member
Author
|
Superseded by #936, which retains this PR as patch-equivalent purpose commits in the consolidated Homebrew publisher batch and reruns the combined validation on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Artifact validation became stricter and the ABI advanced, while resolver tests still hardcoded ABI 4 and emitted empty or minimally invalid Wasm. The fixtures were therefore exercising stale artifacts instead of the intended resolver behavior.
Validation
./scripts/dev-shell.sh bash -c 'HOST_TARGET="$(rustc -vV | awk '\\/^host/ {print $2}'\\)"; cargo test -p xtask --target "$HOST_TARGET"'(350 passed)