[Podcast Feed Reload] Pull Down to Reload feed #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private func setupLayout() { | ||
| refreshLabel.translatesAutoresizingMaskIntoConstraints = false | ||
| refreshLabel.leadingAnchor.constraint(equalTo: leadingAnchor).isActive = true |
There was a problem hiding this comment.
Don't you prefer to do NSLayoutConstraint.activate([...]) instead of one by one?
There was a problem hiding this comment.
I do but I kept the same as the other component
SergioEstevao
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2705
This PR adds the pull down to reload to call the view model and invoke the API. The component used for the pull down is called
CustomRefreshControl, which extends the systemUIRefreshControl. The instance is set to the table view propertyrefreshControland it's not manually added as subview.This because the
PCRefreshControldoes some computations to the scroll view edge inset which interferes with the view controller and its custom navigation bar and search controller.IWAGE5365.MOV
To test
podcastFeedUpdateenabledChecklist
CHANGELOG.mdif necessary.