Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update share icon and transcript positions #2747

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

danielebogo
Copy link
Contributor

Fixes #2727

Replace Transcript icon with Share

Shelf More
RocketSim_Screenshot_iPhone_16_6 1_2025-02-13_09 16 55 RocketSim_Screenshot_iPhone_16_6 1_2025-02-13_09 17 42

To test

  1. Install the app fromtrunk.
  2. Play something.
  3. Change your shelf items order.
  4. Install the app from this branch.
  5. Go to the player. Notice that the order of shelf items has not changed.
  6. Delete the app and restart.
  7. Start the app.
  8. Play something.
  9. Confirm that share icon is the 4th item in the shelf
  10. Tap the ••• in shelf and confirm transcript is the 2nd item in More Action.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added [Type] Enhancement Improve an existing feature. Player labels Feb 13, 2025
@danielebogo danielebogo added this to the 7.83 milestone Feb 13, 2025
@danielebogo danielebogo requested a review from a team as a code owner February 13, 2025 05:46
@pocketcasts pocketcasts modified the milestones: 7.83, 7.84 Feb 17, 2025
@pocketcasts
Copy link
Contributor

Version 7.83 has now entered code-freeze, so the milestone of this PR has been updated to 7.84.

@SergioEstevao SergioEstevao changed the base branch from trunk to release/7.83 February 17, 2025 15:36
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit 77872c6 into release/7.83 Feb 17, 2025
6 of 13 checks passed
@SergioEstevao SergioEstevao deleted the danieleb/share-icon-shelf branch February 17, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Player [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "transcripts" for "share" as default in the action bar
3 participants