Remove code behind FeatureFlag.newSettingsStorage and FeatureFlag.settingsSync#4640
Open
kean wants to merge 1 commit into
Open
Remove code behind FeatureFlag.newSettingsStorage and FeatureFlag.settingsSync#4640kean wants to merge 1 commit into
kean wants to merge 1 commit into
Conversation
kean
added
settings
kean
added
settings
Collaborator
Generated by 🚫 Danger |
kean
commented
Jun 29, 2026
| } else { | ||
| return showArchived | ||
| } | ||
| showArchived |
Contributor
Author
There was a problem hiding this comment.
As step two, I can remove these now redundant properties.
…tingsSync Both flags were permanently disabled in production (shouldEnableSyncedSettings was hardcoded to false), so the flag-on "synced settings storage" paths were dead. Keep the legacy behavior, remove the flag-gated branches, the two flags, and the support code that became unused (settings import/migration, apiSettings, processSettings, named-settings sync extensions). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kean
force-pushed
the
remove-new-settings-storage-flags
branch
from
3e3ed73 to
db3b09b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all code gated by
FeatureFlag.newSettingsStorageandFeatureFlag.settingsSync, along with the two flags themselves.To test
Checklist
CHANGELOG.mdif necessary.