Skip to content

PCIOS-805: Fix transcript controls layout shift causing mis-taps #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pocketcasts wants to merge 2 commits into
base: trunk
Choose a base branch
from
+18 −8
Open

PCIOS-805: Fix transcript controls layout shift causing mis-taps #4655

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667b2c2
PCIOS-805: iOS: Transcript controls shift position as the transcript …
pocketcasts Jul 1, 2026
0be9aba
Restore transcript play control on load errors
joashrajin Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions podcasts/TranscriptViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,11 @@ class TranscriptViewController: PlayerItemViewController, AnalyticsSourceProvide
stackView.addArrangedSubview(closeButton)
stackView.addArrangedSubview(UIView())

if FeatureFlag.shareTranscripts.enabled {
stackView.addArrangedSubview(shareButton)
}
shareButton.isHidden = !FeatureFlag.shareTranscripts.enabled
stackView.addArrangedSubview(shareButton)

if showFromEpisode {
stackView.addArrangedSubview(playButton)
}
playButton.isHidden = !showFromEpisode
stackView.addArrangedSubview(playButton)

stackView.addArrangedSubview(searchButton)

Expand Down Expand Up @@ -602,18 +600,26 @@ class TranscriptViewController: PlayerItemViewController, AnalyticsSourceProvide

private func setupLoadingState() {
transcriptView.isHidden = true
searchButton.isHidden = true
setControlButtonsVisible(false)
errorView.isHidden = true
activityIndicatorView.startAnimating()
}

private func setupShowTranscriptState() {
transcriptView.isHidden = false
searchButton.isHidden = false
setControlButtonsVisible(true)
errorView.isHidden = true
activityIndicatorView.stopAnimating()
}

private func setControlButtonsVisible(_ visible: Bool) {
let buttons: [UIButton] = [searchButton, shareButton, playButton]
for button in buttons where !button.isHidden {
button.alpha = visible ? 1 : 0
button.isUserInteractionEnabled = visible
}
}

private var currentEpisodeUUID: String?

private func loadTranscript() {
Expand Down