Cast HLS streams correctly on Chromecast#4687
Open
leandroalonso wants to merge 1 commit into
Open
Conversation
We assume HLS is always video.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Chromecast playback for episodes delivered via HLS manifests by ensuring the Cast receiver is given the correct media classification and MIME type, so video-capable HLS streams render as video instead of audio-only.
Changes:
- Treat streamed HLS episodes as video for Google Cast metadata (
.movie) to encourage video rendering on the receiver. - Set Cast
contentTypeto the HLS MIME type when casting an HLS manifest URL. - Expose
Episode.hlsEnclosureTypepublicly fromPocketCastsDataModelso the app target can reuse the canonical MIME type constant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| podcasts/Google Cast/GoogleCastManager.swift | Detect HLS streaming and adjust Cast metadata type + content MIME type accordingly. |
| Modules/Sources/PocketCastsDataModel/Public/Model/Episode+fromDictionary.swift | Makes hlsEnclosureType public so it can be referenced by the app module when building Cast media info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PCIOS-812
Makes Chromecast cast HLS streams correctly. Builds on the HLS audio/video toggle work.
To test
Note
Requires a real Chromecast device.
Checklist
CHANGELOG.mdif necessary.