Skip to content

Fix bottom bars turning gray under some conditions on home grid#4689

Merged
kean merged 8 commits into
trunkfrom
kean/fix-tab-bar-turning-gray
Jul 7, 2026
Merged

Fix bottom bars turning gray under some conditions on home grid#4689
kean merged 8 commits into
trunkfrom
kean/fix-tab-bar-turning-gray

Conversation

@kean

@kean kean commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Under Liquid Glass on iOS 26, the floating tab bar / mini player turned gray/dark over the All Podcasts grid because the system scroll edge effect washes out over the colorful artwork.

Leaving a full gap with no content at the bottom of the grid (plus a soft fade into the background) seems to solve it — no guarantee, but it holds up in my testing. Visually it looks about the same as before, and the collapsed tab bar state is a bit improved.

To test

  1. On an iOS 26 device/simulator with Liquid Glass enabled, open the Podcasts tab.
  2. Scroll the grid and confirm the floating tab bar / mini player stays legible instead of turning gray/dark.
  3. Start playback and repeat with the mini player showing.
  4. On iOS 27 and iPad, check that the fade is not used

Before, the bar sometimes turning gray due to dynamic sampling

IMG_7708

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the Event Horizon schema to reflect any new or changed analytics.

@kean kean requested a review from a team as a code owner July 6, 2026 21:21
Copilot AI review requested due to automatic review settings July 6, 2026 21:21
@kean kean added this to the 8.16 milestone Jul 6, 2026
@kean kean added [Type] Bug Used for issues where something is not functioning as intended. UI Related UI related issues (colors, icons, etc) labels Jul 6, 2026
@kean kean requested review from SergioEstevao and removed request for a team July 6, 2026 21:21
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dangermattic

dangermattic commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 8.16. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the All Podcasts grid’s bottom treatment under iOS 26 “Liquid Glass” to prevent the floating tab bar / mini player from becoming visually “washed out” over colorful artwork by introducing a spacing gap and a progressive fade-to-background overlay.

Changes:

  • Tuned ProgressiveFadeView’s gradient ramp and alpha stops for a softer, earlier fade.
  • Reworked PodcastListViewController’s bottom fade behavior to add bottom spacing, install a fade overlay, and toggle it based on iOS version + idiom/traits.
  • Added a changelog entry documenting the Liquid Glass grid readability fix.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
podcasts/Utilities/ProgressiveFadeView.swift Adjusts gradient stops/alpha ramp for the progressive fade overlay.
podcasts/Podcasts/All Podcasts/PodcastListViewController.xib Wires up a new outlet to control the collection view’s bottom constraint.
podcasts/Podcasts/All Podcasts/PodcastListViewController.swift Implements bottom spacing + fade overlay install/toggling for iOS 26 phone idiom under Liquid Glass.
CHANGELOG.md Adds a user-facing entry for the iOS 26 Liquid Glass grid readability fix.

Comment on lines +345 to +350
guard enabled else {
bottomFadeView.isHidden = true
collectionViewBottomConstraint.constant = 0
podcastsCollectionView.bottomEdgeEffect.isHidden = false
return
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense the above?

@kean kean changed the title Fix floating bottom bars turning gray over the All Podcasts grid under Liquid Glass Fix bottom bars turning gray under some conditions on home grid Jul 6, 2026

@SergioEstevao SergioEstevao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working correctly on my tests!

@kean kean merged commit fa7bc3c into trunk Jul 7, 2026
4 checks passed
@kean kean deleted the kean/fix-tab-bar-turning-gray branch July 7, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Used for issues where something is not functioning as intended. UI Related UI related issues (colors, icons, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants