Skip to content

Allow URLs in the SQL import command#2375

Merged
luismulinari merged 5 commits into
trunkfrom
sql-import-url
Jun 3, 2025
Merged

Allow URLs in the SQL import command#2375
luismulinari merged 5 commits into
trunkfrom
sql-import-url

Conversation

@luismulinari

@luismulinari luismulinari commented May 27, 2025

Copy link
Copy Markdown
Contributor

Description

Recently, we've seen more requests to import large SQL files. Uploading large files can be challenging due to connection issues and our legacy VIP-CLI S3 multipart uploader.

This PR improves this experience by allowing SQL imports using a URL instead of uploading raw files.

Pull request checklist

New release checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run node ./dist/bin/vip-import-sql.js <site> <URL> --md5 <md5>

@github-actions

github-actions Bot commented May 27, 2025

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sonarqubecloud

Copy link
Copy Markdown

@luismulinari luismulinari marked this pull request as ready for review May 27, 2025 17:47
@luismulinari luismulinari requested a review from a team May 27, 2025 17:47

@rebeccahum rebeccahum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, only thing I'd add for a TODO is if the md5 mismatch on user input, to not trigger an error in PD.

@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2025

Copy link
Copy Markdown

@luismulinari luismulinari merged commit 93ec8f4 into trunk Jun 3, 2025
19 checks passed
@luismulinari luismulinari deleted the sql-import-url branch June 3, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants