Reject symlinked .vipgoci_* committed files before reading#397
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens local repository file reads by rejecting committed files that are symbolic links before their contents are read, reducing the risk of reading unintended targets via symlink traversal.
Changes:
- Build a single
$file_pathfor the requested committed file and reuse it for reads. - Add an
is_link()guard to refuse reading symlinked files, with logging and an earlyfalsereturn. - Keep existing runtime measurement behavior, stopping the timer on both success and early-return paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rebeccahum
force-pushed
the
fix/reject-symlink-config-files
branch
2 times, most recently
from
d65dcbd to
2f71bf2
Compare
rebeccahum
force-pushed
the
fix/reject-symlink-config-files
branch
from
2f71bf2 to
cf19bd7
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ic/vip-go-ci into fix/reject-symlink-config-files
robersongomes
approved these changes
Jul 6, 2026
There was a problem hiding this comment.
Is this supposed to be versioned?
Contributor
Author
There was a problem hiding this comment.
Adding an ignore for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.