-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Pendo Track events #6140
Open
chriszarate
wants to merge
4
commits into
develop
Choose a base branch
from
add/pendo-track-page-feature-events
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6140 +/- ##
=============================================
+ Coverage 30.41% 30.99% +0.57%
- Complexity 4830 4879 +49
=============================================
Files 290 296 +6
Lines 21333 21500 +167
=============================================
+ Hits 6489 6664 +175
+ Misses 14844 14836 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7 tasks
3e92aa5
to
dd01619
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide telemetry for Pendo "Track events." These events are conceptually similar to Automattic Tracks events, but have a different payload structure. See an explanation of "Event types" on this page.
Usage is almost identical to that of Automattic Tracks. This PR introduces a generic
Telemetry
class that will send events to both Automattic Tracks and Pendo. Going forward, we will update our plugins to use theTelemetry
class.In general, I've tried to follow the implementation pattern provided by the existing Tracks implementation and the generic Telemetry base classes and interfaces. I did make some minor changes to the abstract class
Telemetry_Event
and the extendingTracks_Event
class in order to improve the abstraction and reduce code duplication.New constants will need to be provided in order to configure this functionality automatically:
VIP_PENDO_TRACK_INTEGRATION_KEY
: The integration API key used to authenticate with Pendo and send Track events. This key can only be used to write (append) events to Pendo's API.VIP_SF_ACCOUNT_ID
: The account ID added to event payloads and used to correlate Pendo events.Note
Client-side Pendo Page/Feature events has moved to #6150
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
Telemetry
class and record events.