Skip to content

Fix vip-real-time-collaboration integration failed constant checks#6740

Merged
maxschmeling merged 2 commits intodevelopfrom
remove/constant-defined-checks
Jan 28, 2026
Merged

Fix vip-real-time-collaboration integration failed constant checks#6740
maxschmeling merged 2 commits intodevelopfrom
remove/constant-defined-checks

Conversation

@maxschmeling
Copy link
Copy Markdown
Contributor

@maxschmeling maxschmeling commented Jan 28, 2026

Description

Fixes an issue from #6731 where the vip-real-time-collaboration integration constants were moved to class constants but the defined() checks weren't removed.

Changelog Description

Fixed

  • The vip-real-time-collaboration integration loading issues.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

@maxschmeling maxschmeling requested a review from a team as a code owner January 28, 2026 00:50
Copilot AI review requested due to automatic review settings January 28, 2026 00:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Real-Time Collaboration (RTC) integration so it no longer relies on undefined global version constants and instead consistently uses internal class constants, ensuring the integration can resolve the correct plugin and Gutenberg paths.

Changes:

  • Standardizes RTC plugin loading to use the RealTimeCollaborationIntegration::VIP_RTC_PLUGIN_VERSION class constant when building the plugin path.
  • Standardizes RTC Gutenberg loading to use the RealTimeCollaborationIntegration::VIP_RTC_GUTENBERG_VERSION class constant, simplifying the logic for choosing the unversioned vs. versioned Gutenberg folders.
  • Updates the default Gutenberg version string from 22.4.1-f48ad9c to 0.2, aligning it with the RTC plugin version constant.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.22%. Comparing base (05d1923) to head (3bd5f2b).
⚠️ Report is 16 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6740      +/-   ##
=============================================
+ Coverage      35.19%   35.22%   +0.02%     
+ Complexity      5085     5081       -4     
=============================================
  Files            295      295              
  Lines          20844    20840       -4     
=============================================
+ Hits            7337     7341       +4     
+ Misses         13507    13499       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@maxschmeling maxschmeling enabled auto-merge (squash) January 28, 2026 01:04
@maxschmeling maxschmeling merged commit 7eb5d71 into develop Jan 28, 2026
50 checks passed
@maxschmeling maxschmeling deleted the remove/constant-defined-checks branch January 28, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants