-
Notifications
You must be signed in to change notification settings - Fork 72
[E2E][QIT] Migrate subscriptions e2e specs #11078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mgascam
wants to merge
143
commits into
dev/qit-e2e-merchant-specs-migration
Choose a base branch
from
dev/qit-e2e-subscriptions-specs-migration
base: dev/qit-e2e-merchant-specs-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[E2E][QIT] Migrate subscriptions e2e specs #11078
mgascam
wants to merge
143
commits into
dev/qit-e2e-merchant-specs-migration
from
dev/qit-e2e-subscriptions-specs-migration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced WP-CLI commands for QIT setup and status checks to assist in development environments. - Created a new class `WP_CLI_QIT_Dev_Command` for handling Jetpack connection setup and account data refresh. - Added E2E test runner script and configuration for QIT, including basic tests for WooCommerce Payments functionality. - Updated package.json to include a new script for running QIT E2E tests. - Enhanced default environment configuration for QIT testing with necessary credentials. - Implemented setup script for WooCommerce Payments E2E tests to configure products, customers, and Jetpack connections. - Added ESLint configuration for E2E tests to accommodate Playwright testing framework. - Created initial E2E test cases to verify basic functionality and plugin activation.
…nce setup functions, and add connection validation tests
- Add .github/workflows/qit-e2e.yml with comprehensive CI setup - Support multiple WooCommerce and PHP version combinations - Enable manual workflow dispatch with custom parameters - Update e2e-runner.sh to handle CI environment options - Add CI.md documentation explaining workflow usage and setup The workflow runs on PR, push to main branches, scheduled, and manual dispatch. Includes proper authentication and environment variable handling for CI context.
Security improvements: - Add GitHub Actions log masking for all sensitive tokens - Use environment variables instead of command-line arguments in WP-CLI - Update WP_CLI_QIT_Dev_Command to prioritize env vars over CLI args - Remove tokens from command-line to prevent exposure in process lists - Add comprehensive security documentation and best practices This prevents token leakage through: - Process lists (ps aux) - Command history - GitHub Actions logs - Error output and debugging info All tests continue to pass with enhanced security measures.
…erchant-specs-migration
…subscriptions-specs-migration
…unt configuration
…erchant-specs-migration
…subscriptions-specs-migration
…d activate Storefront theme
…erchant-specs-migration
…subscriptions-specs-migration
…erchant-specs-migration
…subscriptions-specs-migration
cc5ba36 to
37b73dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #WOOPMNT-5347
This PR builds on #11071.
It completes the migration of all WooCommerce Subscriptions E2E tests to the QIT framework and removes environment-based skip flags in favor of Playwright's native tag-based filtering system.
Changes proposed in this Pull Request
Tag-Based Filtering
Removed environment-based skip flags from all QIT specs:
Now using Playwright tags:
Benefits:
npm run test:qit-e2e -- --tag=subscriptions--tag="critical & subscriptions"Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge