Track the group-less engine catalog#14
Merged
Merged
Conversation
The engine removed plan groups: plans are a single flat catalog table and Plan::create() takes the attribute array alone. Lite consumes no group data anywhere, so the pin refresh only needs the test seeding helper moved off the removed PlanGroup entity and repository.
vbelolapotkov
force-pushed
the
update/group-less-plans-api
branch
from
16d34bd to
c76cc30
Compare
Contributor
Author
|
That's mostly a cleanup, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to the engine catalog flatten (woocommerce/woocommerce#66313, WOOSUBS-1787): the engine removed plan groups (plans are now a single flat catalog table with a per-plan
merchant_codeidempotency key). Lite consumes no group data anywhere - the plans app already presents plans flat - so this PR only refreshes the vendored engine reference and adapts the integration test seeding helper to the newPlan::create( array )signature (off the removedPlanGroupentity and repository).Rebased onto trunk after the wp-env test-stack migration (#15) and the settings-move (#12): the old unit-suite and stub fixes this branch carried targeted deleted files and were dropped, reducing the PR to the engine pin plus the one helper adaptation.
Merge after the engine flatten ships in the vendored package.
Testing
composer lint,composer test:integration(full suite green against the flattened engine: 66 tests),npm run lint:js/lint:css/build.