Skip to content

Conversation

@Menrath
Copy link
Contributor

@Menrath Menrath commented Nov 12, 2025

Likely there are more errors.

Almost everything could be an array! Though I agree not encouraging the use in the setters for certain things, when parsing remote stuff it should be considered!

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Corrected PHPDoc types in Base_Object class to accurately reflect that certain properties can return arrays.

@matticbot
Copy link
Contributor

👋 Thanks for your contribution!

I see you have provided all the required changelog information in your PR description. To complete the process, you'll need to create a changelog file in your branch.

Please create a file named .github/changelog/2451-from-description with this content:

Significance: patch
Type: fixed

Corrected PHPDoc types in Base_Object class to accurately reflect that certain properties can return arrays.

You can do this by either:

  1. Running composer changelog:add in your local repository, or
  2. Creating the file manually with the content above

Once you've committed and pushed the file to your PR branch, the checks will pass automatically.

@obenland
Copy link
Member

@Menrath Could you add a changelog message as well, following the guidance here? I'm unable to add it myself on external PRs. Should be all that's left.

@pfefferle
Copy link
Member

I think we an also add the "Skip Changelog" label, because this change is not really user-facing.

@pfefferle pfefferle added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Nov 13, 2025
@pfefferle pfefferle merged commit f40fafe into Automattic:trunk Nov 13, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OSS Citizen Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants