Skip to content

Domains: Replace the inaccurate "type" with a new "subtype" #105577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Domains: Replace the inaccurate "type" with a new "subtype" #105577

wants to merge 5 commits into from

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Sep 4, 2025

Part of DOTDASH-339

Proposed Changes

  • Replaced domain type with subtype

Why are these changes being made?

Testing Instructions

  • Go to /v2/domains
  • Check the "Type" field; it renders subtype.label provided from the BE
Screenshot 2025-09-04 at 17 40 42

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team September 4, 2025 15:41
@bogiii bogiii self-assigned this Sep 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-154633
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-154633&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-154633&env=a8c-for-agencies

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 4, 2025
bogiii
bogiii commented Sep 4, 2025
View reviewed changes
client/dashboard/domains/dataviews/actions.tsx Outdated
@@ -94,6 +94,7 @@ export const useActions = ( { user, site }: { user: User; site?: Site } ) => {
window.location.pathname = domainManagementLink( domain, siteSlug, false );
},
isEligible: ( item: DomainSummary ) => {
// What is DomainSubtype equivalent to DomainTypes.WPCOM?
return item.type !== DomainTypes.WPCOM;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gius80, can you help me with this?
What is DomainSubtype equivalent to DomainTypes.WPCOM?

@matticbot
Copy link
Contributor

matticbot commented Sep 4, 2025 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/DOTDASH-339 on your sandbox.

@bogiii bogiii marked this pull request as ready for review September 5, 2025 09:21
@bogiii bogiii requested a review from a team as a code owner September 5, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bogiii bogiii

Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogiii @matticbot