Skip to content

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Sep 25, 2025

Resolves DOTDASH-368

Proposed Changes

  • This PR fixes the validation message for the Name Server field. It now shows the proper message when the field value is invalid.
  • It also fixes the suffix looking bad when the domain name is too long.

As discussed here, this is using an experimental component, which may change in the future. This makes testing even more important, so I'm suggesting focusing on that next - DOTDASH-387.

Before:

image

After:

image

Why are these changes being made?

  • This improves the UX and looks of the screen.

Testing Instructions

  • Go to http://calypso.localhost:3000/v2/domains/[domain]/glue-records/add and try entering an invalid name server.
  • You should see an error message.
  • Enter valid values and make sure the form can be submitted as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@m1r0 m1r0 requested a review from a team September 25, 2025 15:52
@m1r0 m1r0 self-assigned this Sep 25, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 25, 2025
Copy link

github-actions bot commented Sep 25, 2025

@m1r0 m1r0 marked this pull request as ready for review September 25, 2025 15:56
@m1r0 m1r0 requested a review from a team as a code owner September 25, 2025 15:56
@matticbot
Copy link
Contributor

matticbot commented Sep 25, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/glue-records-validation on your sandbox.

@m1r0 m1r0 force-pushed the fix/glue-records-validation branch from 9b92593 to 29029d7 Compare September 26, 2025 09:28
// TODO: Show the error via Data Form when the ValidatedInputControl component is ready.
<InputControl
__next40pxDefaultSize
<ValidatedInputControl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to apply changes to SuffixInputControl component, and then we can reuse it elsewhere 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I've updated the component in db5a7d4. Could you give it a quick look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants