Skip to content

Conversation

xavier-lc
Copy link
Contributor

Part of DSGCOM-209

Proposed Changes

  • Use the /marketplace/products endpoint on both the dashboard and the inspector so we can show the icon for some woocommerce products that were showing up without it.
  • Provide the icon as a string to the consumer components so they don't have to guess where to get it.

Why are these changes being made?

  • The icon was not being shown for all plugins.

Testing Instructions

  • Open the Calypso live link
  • Go to /v2/plugins
  • Check that the WooCommerce Additional Variation Images and WooCommerce Back In Stock Notifications plugins show up with an icon:
image

In order to have them installed, you'll need to use an account with the a8c.com and this coupon: PCYsg-65X-p2

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@xavier-lc xavier-lc self-assigned this Sep 25, 2025
@xavier-lc xavier-lc requested a review from a team as a code owner September 25, 2025 20:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 25, 2025
@xavier-lc xavier-lc requested a review from a team September 25, 2025 20:46
Copy link

github-actions bot commented Sep 25, 2025

@xavier-lc xavier-lc requested a review from rcrdortiz September 25, 2025 20:46
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/marktplace-plugins-requests on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants