-
Notifications
You must be signed in to change notification settings - Fork 2k
Domain Search Rewrite: Make sure Start flows behave correctly #106054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this and I'm not sure I'm doing it correctly 😅 I noticed some differences between this PR and production. For example:
Most of the flows are showing the "Exact match", " is a common extension" notes in the features suggestions, but they aren't present in production. Also, the "Use a domain I own" link doesn't appear in this PR:


Are these changes intentional?
I think the one that was most different was `/start/onboarding-with-email:

Despite the UI changes and the omission of the "Use a domain I own" flow, I believe the behavior is the same with production.
6526a33
to
a464aa7
Compare
That was fixed in a different PR and simply rebasing this one should do the trick. Please try again.
@ollierozdarz, should we show the escape hatch to use my domain despite the user not searching for a FQDN? I think it makes the behavior a bit ambiguous since they'll see both escape hatches if they do search for it. |
@zaguiini is this just for the I don't have any context as to why there is, or isn't, a Side note, we should make sure we keep the same heading on these specialized flows: ![]() |
ca94e3e
to
626c97c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed again and the new flows are more similar to the ones in prod 🙂 the behavior between this PR and prod is the same in all flows, but there are still some small UI differences. I've screenshotted each of the flows and pointed out those differences:
I noticed a weird behavior in the /start/launch-site
domain search:
Screen.Recording.2025-09-29.at.16.09.37.mov
I think this isn't related to this PR and the culprit seems to be the hide_initial_query=yes
parameter. Removing it solves the issue with the query clearing on its own.
Thanks for the fantastic review, @leonardost! I think I addressed most of concerns, notably excepting:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this, @zaguiini!
/start/domain should have the use my domain link at the top-right because it's possible to transfer a domain from that flow. Prod not having it is a bug;
/start/free shouldn't have the free plan banner and that's a bug in prod. We're not offering plans in that flow;
/start/with-theme I think having the free for a year discount is actually correct as we're showing the plans step as the user progresses. It's a production bug apparently. The same for onboarding-with-email.
With these considerations, I believe everything LGTM!
There's one very minor thing, there's a border in the second step of the "Use a domain I own" flow:

It shows in all the flows except for /start/launch-site
.
Part of DOMAINS-1674.
Proposed Changes
Adds feature parity with production in all eligible
/start
flows, in order of importance:/start/launch-site?siteSlug=%s
/start/domain
/start/free
,/start/premium
,/start/business
etc.)/start/with-theme?theme=retrospect&theme_type=free&intervalType=yearly
/start/with-plugin?plugin=dokan-lite&billing_period=
/start/domain-for-gravatar
/start/onboarding-with-email
/start/onboarding-affiliate
Testing Instructions
Turn the
domain-search-rewrite
feature flag on and verify all of the flows behave like production: the ability to skip, to use an existing domain, the free domain discount, etc.Don't worry about Tracks events as they'll be introduced in #105944.