-
Notifications
You must be signed in to change notification settings - Fork 2k
Backups: show dates in the site timezone #106060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran some tests, and it works as expected 👍🏽
Since this affects the useFormattedTime
hook, I’d love to hear @Automattic/lego’s thoughts as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this affects the useFormattedTime hook, I’d love to hear @Automattic/lego’s thoughts as well.
I think it will be beneficial for everyone to add tests to the useFormattedTime()
hook. I got lost reading the changes 😂
Tests were added and can be run with:
Can you please check again? |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@fushar Hi. This is a gentle ping in case you missed the last week one. Can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping. Tests are nice. Thanks!
Part of DOTDASH-543.
This PR is related to #105954, but doesn't depend on it.
Proposed Changes
useFormattedTime
hook.Why are these changes being made?
When the
DateRangePicker
component is fixed, we'll use the site timezone to filter dates. We need to display them in the same timezone to avoid inconsistencies, like an entry being displayed the day before/after the filtering.This is also in line with the way Jetpack Cloud handles timezones:
Testing Instructions
/v2/sites/:slug/backups
Pre-merge Checklist