Skip to content

Conversation

rcrdortiz
Copy link
Contributor

Part of:
https://linear.app/a8c/issue/DSGCOM-283/hosting-dashboard-plugins-make-tracking-events-non-interpolated

Proposed Changes

  • Event names are now string literals with no interpolation

Why are these changes being made?

  • As part of our ongoing effort to modernize the hosting dashboard.

Testing Instructions

  • Go to v2/plugins
  • You should see that the events get triggered.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@rcrdortiz rcrdortiz requested a review from a team as a code owner September 29, 2025 07:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 29, 2025
Copy link

github-actions bot commented Sep 29, 2025

@matticbot
Copy link
Contributor

matticbot commented Sep 29, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug dsgcom-283-hosting-dashboard-plugins-make-tracking-events-non on your sandbox.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now!

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this

@rcrdortiz rcrdortiz merged commit 1bccb85 into trunk Sep 30, 2025
12 checks passed
@rcrdortiz rcrdortiz deleted the dsgcom-283-hosting-dashboard-plugins-make-tracking-events-non branch September 30, 2025 08:38
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants