Skip to content

Conversation

@valterlorran
Copy link
Contributor

@valterlorran valterlorran commented Dec 2, 2025

Part of DOTCOM-15233

Proposed Changes

Add frontend support for SSH migration flow to match backend implementation.

  • Add 'ssh' to migration type definitions in client/data/site-migration/index.ts and client/dashboard/utils/site-status.ts
  • Update migration-pending component to redirect SSH migrations to the verification step
  • Add test coverage for SSH migration stickers (migration-pending-ssh, migration-started-ssh, migration-completed-ssh)
  • Added the support for the new stickers on the new Hosting Dashboard.

Why are these changes being made?

  • The backend now supports SSH migrations with new stickers. Without these changes, the frontend wouldn't recognize SSH migrations, and users would see incorrect UI states or broken redirects.

Testing Instructions

  • Follow the instructions on: 197299-ghe-Automattic/wpcom
  • Use Calypso Live or apply this PR to your local environment.
  • Navigate to /setup/site-migration, input a site that supports the SSH Migration.
  • Go through the flow, until you reach the Securely share your access
  • Now go through the steps, and input an invalid credentials. This will leave you on the pending state.
  • Navigate to /sites/YOUR_SITE and you should the site on the pending state.
  • Also visit /v2/sites/YOUR_SITE and ensure it also works on the new dashboard.
  • In both pages, please validate that you can go back to the migration.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested a review from markbiek December 2, 2025 22:08
@valterlorran valterlorran self-assigned this Dec 2, 2025
@valterlorran valterlorran requested a review from a team as a code owner December 2, 2025 22:08
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 2, 2025
@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/ssh-migration-stickers on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~49 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
sites-dashboard          +123 B  (+0.0%)      +49 B  (+0.0%)
overview                 +123 B  (+0.0%)      +49 B  (+0.0%)
staging-site              +12 B  (+0.0%)       +5 B  (+0.0%)
site-settings             +12 B  (+0.0%)       +5 B  (+0.0%)
site-performance          +12 B  (+0.0%)       +5 B  (+0.0%)
site-monitoring           +12 B  (+0.0%)       +5 B  (+0.0%)
site-logs                 +12 B  (+0.0%)       +5 B  (+0.0%)
plans                     +12 B  (+0.0%)       +5 B  (+0.0%)
hosting                   +12 B  (+0.0%)       +5 B  (+0.0%)
github-deployments        +12 B  (+0.0%)       +5 B  (+0.0%)
domains                   +12 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@valterlorran valterlorran force-pushed the add/ssh-migration-stickers branch from 6ff0441 to ed6e1b4 Compare December 3, 2025 19:22
@valterlorran valterlorran force-pushed the add/ssh-migration-stickers branch from a6bdd89 to aba8ce2 Compare December 4, 2025 13:23
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valterlorran valterlorran merged commit f0bfc27 into trunk Dec 5, 2025
12 checks passed
@valterlorran valterlorran deleted the add/ssh-migration-stickers branch December 5, 2025 17:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants