-
Notifications
You must be signed in to change notification settings - Fork 2k
SSH Migration: Use the SSH stickers to display the progress #107443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~49 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
6ff0441 to
ed6e1b4
Compare
… domain information
a6bdd89 to
aba8ce2
Compare
markbiek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Part of DOTCOM-15233
Proposed Changes
Add frontend support for SSH migration flow to match backend implementation.
'ssh'to migration type definitions inclient/data/site-migration/index.tsandclient/dashboard/utils/site-status.tsmigration-pending-ssh,migration-started-ssh,migration-completed-ssh)Why are these changes being made?
Testing Instructions
/setup/site-migration, input a site that supports the SSH Migration.Securely share your access/sites/YOUR_SITEand you should the site on the pending state./v2/sites/YOUR_SITEand ensure it also works on the new dashboard.Pre-merge Checklist