Skip to content

Conversation

@chrismccluskey
Copy link
Contributor

@chrismccluskey chrismccluskey commented Dec 2, 2025

Fixes SHILL-1404

Proposed Changes

  • Hide the error notice shown when one-time purchases cannot be cancelled.

Why are these changes being made?

  • Currently if a one-time purchase cancellation is attempted by visiting the URL directly it will redirect the customer to the purchase management page with an error message saying that the purchase has already been removed. This isn't true - the purchase is still active.

Testing Instructions

  • Add a quick start session via SA
  • Checkout the mccluskeyc/shill-1404 branch to your sandbox
  • Try to cancel that purchase in the multisite dashboard. From /v2/me/billing/purchases click "Manage Purchase" then append /cancel to the end of the URL.
  • You should be redirected back to the same page you were on, but with no error message.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chrismccluskey chrismccluskey requested review from a team as code owners December 2, 2025 23:03
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2025
@chrismccluskey chrismccluskey marked this pull request as draft December 2, 2025 23:03
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/msd-billing-cancel-removal-flow-for-one-off-purchases on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@chrismccluskey chrismccluskey marked this pull request as ready for review December 2, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants