Fix default interval type issues in signup

[dzver]

Part of M4R73CH-1476

Proposed Changes

• Rather than refactor plans to ensure we are always showing an equal-duration or longer-term plan, introduce an order that does it.

Why are these changes being made?

• The setup/plan-upgrade is defaulting to yearly even when I have a longer term plan, which results in broken upsells on the hosting dashboard

Testing Instructions

Use a Summer Special Personal 1-year

• Go to sites/siteid.wpcomstaging.com/settings/sftp-ssh
• Click the upsell
• You should see upgrade buttons

Now repeat with a 2 or 3-year Personal

• Go to sites/siteid.wpcomstaging.com/settings/sftp-ssh
• Click the upsell
• You should see Upgrade buttons

Before:

After:

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-163645

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-163645&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-163645&env=a8c-for-agencies

Dashboard live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-163645&env=dashboard

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/ensure-compatible-intervals-in-plans on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~31 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-main                  -1560 B  (-0.1%)     -147 B  (-0.0%)
entry-reauth-required        -276 B  (-0.0%)      -53 B  (-0.0%)
entry-login                  -276 B  (-0.0%)      -53 B  (-0.0%)
entry-subscriptions          -210 B  (-0.0%)      -33 B  (-0.0%)
entry-domains-landing        -210 B  (-0.0%)      -33 B  (-0.0%)
entry-dashboard-dotcom       -210 B  (-0.0%)      -33 B  (-0.0%)
entry-dashboard-ciab         -210 B  (-0.0%)      -33 B  (-0.0%)
entry-browsehappy            -210 B  (-0.1%)      -33 B  (-0.0%)
entry-stepper                 +89 B  (+0.0%)     +145 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4129 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
plugins                                 +681 B  (+0.0%)      -64 B  (-0.0%)
jetpack-app                             +649 B  (+0.1%)     +362 B  (+0.3%)
async-step-unified-plans                +636 B  (+0.0%)     +171 B  (+0.0%)
jetpack-cloud-agency-dashboard          -350 B  (-0.0%)    -1873 B  (-0.6%)
a8c-for-agencies-plugins                +303 B  (+0.0%)     -249 B  (-0.0%)
site-blocks                             -299 B  (-0.1%)     -153 B  (-0.1%)
security                                -299 B  (-0.0%)     -153 B  (-0.1%)
purchases                               -299 B  (-0.0%)      +53 B  (+0.0%)
privacy                                 -299 B  (-0.1%)     -153 B  (-0.1%)
notification-settings                   -299 B  (-0.0%)     -153 B  (-0.1%)
me                                      -299 B  (-0.1%)     -153 B  (-0.1%)
developer                               -299 B  (-0.1%)     -153 B  (-0.1%)
account-close                           -299 B  (-0.1%)     -153 B  (-0.1%)
account                                 -299 B  (-0.0%)     -153 B  (-0.1%)
plans                                   +264 B  (+0.0%)     +602 B  (+0.1%)
overview                                -260 B  (-0.0%)     -606 B  (-0.1%)
marketplace                             +228 B  (+0.0%)    +1072 B  (+0.4%)
backup                                  -196 B  (-0.0%)    -1061 B  (-0.3%)
activity                                -196 B  (-0.0%)    -1061 B  (-0.4%)
a8c-for-agencies-sites                  -196 B  (-0.0%)    -1061 B  (-0.1%)
jetpack-cloud-partner-portal            -154 B  (-0.0%)     -939 B  (-0.3%)
jetpack-cloud-manage-pricing            -154 B  (-0.0%)     -428 B  (-0.3%)
home                                    -103 B  (-0.0%)     -135 B  (-0.0%)
email                                   -103 B  (-0.0%)      -81 B  (-0.0%)
checkout                                -103 B  (-0.0%)      +18 B  (+0.0%)
a8c-for-agencies-marketplace            -103 B  (-0.0%)      -39 B  (-0.0%)
a8c-for-agencies-express-checkout       -103 B  (-0.0%)      -39 B  (-0.0%)
a8c-for-agencies-client                 -103 B  (-0.0%)      -39 B  (-0.0%)
settings                                 +93 B  (+0.0%)     +798 B  (+0.3%)
jetpack-cloud-plugin-management          +74 B  (+0.0%)     -170 B  (-0.0%)
domains                                  -64 B  (-0.0%)      -26 B  (-0.0%)
jetpack-connect                          -61 B  (-0.0%)     +139 B  (+0.0%)
jetpack-cloud-pricing                    -61 B  (-0.0%)     +109 B  (+0.0%)
jetpack-cloud-features-comparison        -61 B  (-0.0%)     +262 B  (+0.1%)
themes                                   +32 B  (+0.0%)      +41 B  (+0.0%)
theme                                    +32 B  (+0.0%)      +37 B  (+0.0%)
signup                                   -13 B  (-0.0%)      +88 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~210 bytes removed 📉 [gzipped])

name                                              parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +649 B  (+0.1%)     +205 B  (+0.1%)
async-load-signup-steps-plans                          +649 B  (+0.1%)     +205 B  (+0.1%)
async-load-masterbar-cart-masterbar-cart-wrapper       -154 B  (-0.1%)     -428 B  (-1.1%)
async-load-design-blocks                                +32 B  (+0.0%)      +13 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.