Skip to content

Conversation

@chrismccluskey
Copy link
Contributor

Part of SHILL-1403

Proposed Changes

  • Only show the list of changes that will happen with an Atomic site is revert when the plan is being cancelled.

Why are these changes being made?

  • Currently the list of changes that will happen when an atomic site is reverted happens anytime a product for an atomic site is cancelled, which isn't correctly.

Testing Instructions

  1. Purchase a business plan and a premium theme if you don't already have one to cancel.
  2. Apply the WPCOM patch in SHILL-1403 to your sandbox
  3. Start cancelling the theme and confirm that no changes or cancellation features are mentioned.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chrismccluskey chrismccluskey requested review from a team as code owners December 3, 2025 21:55
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 3, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/show-atomic-revert-changes-for-plans-only on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love a simple fix. Thank you!

@chrismccluskey chrismccluskey merged commit 5f95d4c into trunk Dec 4, 2025
14 of 15 checks passed
@chrismccluskey chrismccluskey deleted the fix/show-atomic-revert-changes-for-plans-only branch December 4, 2025 23:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants