desktop: Use install_gems in CI to access cache#112355
Open
mokagio wants to merge 2 commits into
Open
Conversation
matticbot
added
the
[Status] Needs Review
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Desktop mac Buildkite build script to use the CI toolkit’s install_gems command (instead of bundle install) so Ruby gem installs can benefit from caching in CI.
Changes:
- Replaced
bundle installwithinstall_gemsin the mac desktop build command script. - Added Buildkite log section headers around Ruby setup and code signing steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+38
to
+40
| echo "--- :ruby: Setting up Ruby tooling" | ||
| install_gems | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Too eager. It's okay to fail if the command is not available. Better than swallowing and ending up wasting time not having the cache in the long run.
mokagio
force-pushed
the
desktop/ainfra-2510-use-install_gems-and-other-ci-toolkit-utils-in-the-new-wp
branch
from
3ea449c to
398ffc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Addresses https://linear.app/a8c/issue/AINFRA-2510.
A small follow up on the recent Buildkite CI setup for the Desktop apps. Replaces
bundle installwith the CI toolkitinstall_gemscommand, so that we can access cached gems if available.Why are these changes being made?
Slightly faster CI.
Testing Instructions
TBD: I'll past a screenshot of the build here.
Pre-merge Checklist
N.A. These are CI changes only