Skip to content

Conversation

@arcanaxion
Copy link
Contributor

What type of PR is this? (Check all that apply)

  • 🛠 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • ⚡ Optimization
  • 📝 Documentation Update

Description

Revert that change that made selected rows look eccentric. Does not close the issue.

Just want this merged so I don't have to manually patch this every time I install develop

Related Tickets & Documents

How to reproduce the issue

Backporting

This change should be backported to:

  • 3.0
  • 3.1
  • 4.0
  • develop

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the styling for selected table rows by reverting a previous change that made the selection style overly complex. The change removes elaborate visual effects (gradients, shadows, transitions, and rounded corners) in favor of a simple left border indicator.

  • Removes complex styling rules with color mixing, inset shadows, transitions, and border radius
  • Replaces with a minimal left border indicator using the primary color
  • Addresses issue #2748 regarding eccentric selected row appearance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jrobinAV
Copy link
Member

jrobinAV commented Dec 1, 2025

@arcanaxion Can you add a before/after double-screenshot to help us review the PR?

Thx

@arcanaxion
Copy link
Contributor Author

Before

504067138-744cb073-628f-4e84-bdd9-929bb46ae8b8 504067676-fc2e6411-f7c7-443d-b942-e6ac8abb802e

Issue where the hover style "lingers". Notice the hover color is inconsistent (Only affects chrome. Chrome bug?).

table_hover_bug.mp4

After

504073115-4d6a8c96-3e10-4018-8bee-802802b53f23

@arcanaxion arcanaxion requested a review from jrobinAV December 1, 2025 09:54
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results look good to me.

@github-actions
Copy link
Contributor

This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Dec 16, 2025
@github-actions
Copy link
Contributor

This PR has been closed because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@github-actions github-actions bot closed this Dec 31, 2025
@arcanaxion arcanaxion reopened this Jan 5, 2026
@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jan 6, 2026
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less is more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI: Front-End 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants