-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ctrl+Click support for opening context menu on mac #15842
base: master
Are you sure you want to change the base?
Conversation
d907e96
to
1e0bde1
Compare
You can test this PR using the following package version. |
Please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following:
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by AvaloniaUI OÜ and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant AvaloniaUI OÜ, and those who receive the Submission directly b. Patent License. You grant AvaloniaUI OÜ, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to AvaloniaUI OÜ. You agree to notify AvaloniaUI OÜ in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the Republic of Estonia, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and AvaloniaUI OÜ dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
@cla-avalonia agree |
|
} | ||
} | ||
|
||
public static bool operator ==(PointerGesture? left, PointerGesture? right) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class can be a simple record from how it looks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Also, there is a point about the entire thing being a gesture recognizer. |
|
||
if (KeyModifiers.HasAllFlags(KeyModifiers.Control)) | ||
{ | ||
s.Append("Ctrl"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently accepted a new key formatter API that helps to avoid hardcoding these key strings. It should be integrated here as well #15828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed - in latest commits I just reuse the code from KeyGesture.
But now I have some doubts about string format. Mouse buttons have rather short names, so
Ctrl+Left may look confusing, especially because there may be the same KeyGesture. Need to either remove ToString for now, or agree on some distinguishable button naming.
Also, how was the problem with Ctrl+Click being used for list item selection resolved? |
1e0bde1
to
8b67ae1
Compare
You can test this PR using the following package version. |
I think there is no problem with it. Ctrl+Click will select clicked ListBoxItem and open context menu on it, just like right click does. On mac toggling is performed with Cmd, so no conflict here.
Can you please clarify what do you mean? |
You can test this PR using the following package version. |
What does the pull request do?
Fixes #12828
I recreated previous request (see #12829), commit was reworked according to discussions, now it has only minimal sufficient changes.
I removed handling PointerPressed event that was performed in previous PR. So it will not cover some cases like having context menu on control that has some logic on left pointerpressed, but these are rare cases that can be considered separately.
What is the current behavior?
Ctrl+Click on MacOS does nothing
What is the updated/expected behavior with this PR?
Ctrl+Click now opens context menu on MacOS
Fixed issues
Fixes #12828