[WIP] Previewer Debug #16032
Draft
[WIP] Previewer Debug #16032
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
| var timeout = TimeSpan.FromMinutes(1); | ||
| time.Start(); | ||
|
|
||
| // wait for the debugger to be attacked or timeout. |
There was a problem hiding this comment.
You used "attacked" instead of "attached" here.
kekekeks
reviewed
Jun 16, 2024
| { | ||
| // According this https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.debugger.launch?view=net-6.0#remarks | ||
| // documentation, on not windows platform Debugger.Launch() always return true without running a debugger. | ||
| if (System.Diagnostics.Debugger.Launch()) |
There was a problem hiding this comment.
I feel we have exact same logic somewhere else. Maybe move it to a shared cs file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues