-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Seconds to TimePicker #16079
Open
begleysm
wants to merge
5
commits into
AvaloniaUI:master
Choose a base branch
from
begleysm:add_seconds_to_timepicker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+391
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nless UseSeconds == true.
You can test this PR using the following package version. |
|
@cla-avalonia agree |
1 similar comment
@cla-avalonia agree |
jmacato
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adds support for Seconds to the
TimePicker
Control (which currently only supports Hours and Minutes). It adds aUseSeconds
Property which defaults tofalse
. It addresses a need being tracked in Issue #12045.What is the updated/expected behavior with this PR?
Usage of existing
TimePicker
Controls should see no change since the newUseSeconds
Property is optional and defaults tofalse
which results in theTimePicker
behaving just as it did before.How was the solution implemented (if it's not obvious)?
I first went through and added the Seconds column by finding all of the references to Minutes and duplicating their behavior. I expanded the
PickerHosts
,TextBlocks
,Dividers
, etc and updated theClockIdentifier
column to be to the right of the new Seconds column. I then went through and found all of the references toClockIdentifier
and use it as a template on how to show/hide the new Seconds column based on my newUseSeconds
property. Everywhere possible I tried to use naming consistent with the existing parameters. I also updated the DateTimePickerPage of the ControlCatalog to demonstrate the newUseSeconds
feature. I added a updated one of the Unit Tests and added a Unit Test.Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #12045
Example Screenshot