Fix headless FontManager leak #19599
Merged
+61
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
For each test executed we recreate application services, isolating them. Including font manager. But we do not dispose these, keeping all the native memory alive.
There are really two options to solve it:
managed holds native, native holds managed
reference loop in GlyphTypefaceImpl.Face GetTable delegate.While #2 sounds reasonable to do, FontManager is practically a singleton in normal (non-unit test) applications, and won't do much there. And we still have to properly dispose AvaloniaLocator services after we don't use them.
Checklist
I hope
LeakTests
won't be flaky one. But also can't use dotMemory extensions properly there, as FontManager is allocated and destroyed outside of the test method itself.