Skip to content

Conversation

@zacfromaustinpowder
Copy link
Contributor

@zacfromaustinpowder zacfromaustinpowder commented Oct 27, 2025

This Avalonia PR must be merged before this PR is entirely accurate.

@maxkatz6 maxkatz6 self-requested a review October 27, 2025 05:00
@luke-whos-here luke-whos-here merged commit a3f1f63 into AvaloniaUI:main Oct 27, 2025
2 checks passed
@zacfromaustinpowder zacfromaustinpowder deleted the twoWayFuncValConv branch October 27, 2025 23:09
@maxkatz6
Copy link
Member

@luke-whos-here sorry, I approved preemptively and then re-requested review again. This change should be blocked until AvaloniaUI/Avalonia#19920 is merged in the framework itself. I.e. it documents feature that doesn't yet exist.

@zacfromaustinpowder
Copy link
Contributor Author

zacfromaustinpowder commented Oct 28, 2025

@maxkatz6 just to be clear, the TParam feature already exists for FuncValueConverter, so this addition is valuable whether the other PR gets merged or not. The other PR adds support to FuncValueConverter for converting back, hence the deletion on line 149 in the documentation.

@luke-whos-here
Copy link
Contributor

My bad, folks. I just looked through #19920 again and propose a partial rollback to restore the description in line 149 about not needing to convert back.

luke-whos-here added a commit that referenced this pull request Oct 28, 2025
This is a partial rollback of #746 to restore the description in line 149 about "if you don't need to convert back".

This is because FuncValueConverter is not yet able to convert back. However, the remaining changes added in #746 are true and should be retained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants