Fix verbose of check_clocks for 32 bit systems #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Really minor optional suggestion, would you mind putting the "remove |
|
No Problem, I will do that shortly |
On 32 bit systems uint64_t is long long unsigned int and thus requires %llu in printf to prevent garbled output. Use PRIu64/PRId64 to handle this correctly for both 32 bit and 64 bit systems. Signed-off-by: Florian Kauer <[email protected]>
Signed-off-by: Florian Kauer <[email protected]>
koalo
force-pushed
the
develop/fix-check_clocks-for-32-bit
branch
from
5f82120 to
945aa49
Compare
|
I've splitted the commit now as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32 bit systems uint64_t is long long unsigned int and thus requires %llu in printf to prevent garbled output. Use PRIu64/PRId64 to handle this correctly for both 32 bit and 64 bit systems.
Furthermore, removed err that was never used.