Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable background and font colors #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nizunc
Copy link

@nizunc nizunc commented May 18, 2020

No description provided.

Copy link
Collaborator

@yellowwoods12 yellowwoods12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a description of your changes

@nizunc
Copy link
Author

nizunc commented May 19, 2020

I added a file named theme which inputs color.

@nizunc nizunc requested a review from yellowwoods12 May 26, 2020 06:17
Copy link
Collaborator

@yellowwoods12 yellowwoods12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil7sunny Kindly provide a codepen or a sandbox link of your implementation. It doesn't look correct.

render() {
return (
<div className="App" >
<form action="/action_page.php" onChange = {(e) => this.submitbackground(e)} >
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil7sunny Why is there a php script called here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the php script ,i forgot to remove it earlier. I am adding my codepen link
here : https://codepen.io/__nikhil7sunny__/pen/yLYmzzJ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil7sunny Codepen link isn't working. Please check.

@nizunc
Copy link
Author

nizunc commented May 30, 2020

https://gist.github.com/nikhil7sunny/1c34132ec72cc1e599991b455740f583
can you please check if this is working

Copy link
Member

@arpit9667 arpit9667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil7sunny The third option i.e. to choose the background-color from the dropdown is not working. Please take a look at that. I guess you have already implemented it by giving a color picker option, so maybe you can remove that dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants