-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customizable background and font colors #26
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide a description of your changes
I added a file named theme which inputs color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil7sunny Kindly provide a codepen or a sandbox link of your implementation. It doesn't look correct.
test-server/src/Theme.js
Outdated
render() { | ||
return ( | ||
<div className="App" > | ||
<form action="/action_page.php" onChange = {(e) => this.submitbackground(e)} > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil7sunny Why is there a php script called here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the php script ,i forgot to remove it earlier. I am adding my codepen link
here : https://codepen.io/__nikhil7sunny__/pen/yLYmzzJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil7sunny Codepen link isn't working. Please check.
https://gist.github.com/nikhil7sunny/1c34132ec72cc1e599991b455740f583 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil7sunny The third option i.e. to choose the background-color from the dropdown is not working. Please take a look at that. I guess you have already implemented it by giving a color picker option, so maybe you can remove that dropdown.
No description provided.