-
Notifications
You must be signed in to change notification settings - Fork 45
Image Lazy Loading & Enhanced Loading Experience #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0dd7ad8
LoadingView and Image Lazy Loading
dfsm dbbfda1
Added a 3 second delay to the loading view exit button and progress mβ¦
dfsm ca3530d
First review performed to improve code quality
dfsm 2944b0a
Another code review performed
dfsm 9547576
One more review
dfsm 95a37ef
Final code review?
dfsm b8e16b0
Last code review completed.
dfsm 3df184a
Cleaned up silly comments
dfsm 0d2c7ed
Fix excessive logging for imageLoadProgress
dfsm 651b62f
Removing IntersectionObserver method for manually lazy loading imagesβ¦
dfsm f7aa218
PR cleanup commit
dfsm df52e05
Fixed issue where some tweets were not being embedded but quoted onesβ¦
dfsm 9b5eba3
Final code quality pass (added a new named constant for connectionTimβ¦
dfsm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.