Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date): call onChange with a null value when the date input is cle… #1032

Closed

Conversation

EmmanuelDemey
Copy link

…ared

Related issue

Reference to the issue

close #1002

Description of the issue

The date input call the onChange prop even when the "clear" native behavior is clicked. The component will send a null value.

Person(s) for reviewing proposed changes

@lilian-delouvy

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

Copy link

@RobinGueble RobinGueble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me & resolve a real problem !

arnaudforaison
arnaudforaison previously approved these changes May 15, 2023
Copy link
Contributor

@arnaudforaison arnaudforaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En attente refacto de la build CI

@MartinWeb
Copy link
Contributor

@MartinWeb ajouter des tests avant prise en compte

@MartinWeb
Copy link
Contributor

Correction mergée au sein de cette PR : #1173

@MartinWeb MartinWeb closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot override onReset method of DateInput component
4 participants