Pocket pay contract 3 - #451
Open
abbarrh01 wants to merge 3 commits into
Open
Conversation
add a new test case mirroring the existing lock withdrawal test, verifying all vault state remains unchanged when a regular withdraw fails due to SAC token transfer failure
… docs Add a new `contract_error_codes` test module in the savings vault test suite that validates every ContractError variant panics with its assigned u32 numeric discriminant code. Overhaul the `sdk-error-mapping-guide.md` and `error-codes.md` documentation files to formalize the public error code interface, including categorized error ranges, client-side handling best practices, and reference implementation examples for SDKs and mobile apps.
Create new codebase analysis documents covering repository structure, workflows, and quality/debt assessment. Restructure comprehensive-analysis.md as the main entry point for the analysis package. Update the audit evidence index with the new storage audit map entry, remove the duplicate old vault storage audit map document, and update the last updated date for the audit documentation.
Contributor
| \nThis PR is currently blocked by merge conflicts.\n\nPlease update the branch with the latest main branch and resolve the conflicts before it can be merged. |
Contributor
| \nGitHub has not finished calculating whether this PR can be merged cleanly.\n\nThe auto-merge automation will skip this PR for now. Re-run the automation later. |
Contributor
|
@abbarrh01 please resolve and fix merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #411